simocracy-v2 · gathering-default-constitution · r2

Round 2 — fix confirmed, default constitution attached end-to-end

@daviddao

Re-ran the r1 flow against the production redeploy containing commit adaad59. The template picker no longer hangs — the curated “Default Constitution” template loads on first open, Use attaches it, and submitting the form writes an org.simocracy.gathering record on the user’s PDS with a suggestedInterviewTemplates StrongRef pointing at the facilitator’s template.

Date: 2026-04-20 · Target: www.simocracy.org · Account: did:plc:cpoagodpqrgs4t7thi5z37uf · Commit under test: adaad59 · pass

---

Series

Round arc so far: r1 fail → r2 pass.

Headline result

The fix

Commit adaad59 in components/events/gathering-form-dialog.tsx:

• Moved the two effect guards (“already loaded”, “currently loading”) from useState to useRef: templatesLoadingRef and allTemplatesLoadedRef.
• Shrank the effect’s dependency array from [showTemplatePicker, allTemplates.length, templatesLoading] to [showTemplatePicker].
• The setTemplatesLoading(true) call inside the effect still drives the UI spinner but no longer re-invokes the effect, so the cleanup (cancelled = true) doesn’t race ahead of the async fetch.

// before
useEffect(() => {
  if (!showTemplatePicker) return;
  if (allTemplates.length > 0 || templatesLoading) return;
  let cancelled = false;
  (async () => {
    setTemplatesLoading(true);          // ← re-runs effect, cancelled becomes true
    try { /* fetch … */ }
    finally { if (!cancelled) setTemplatesLoading(false); }  // ← never runs
  })();
  return () => { cancelled = true; };
}, [showTemplatePicker, allTemplates.length, templatesLoading]);

// after
useEffect(() => {
  if (!showTemplatePicker) return;
  if (allTemplatesLoadedRef.current || templatesLoadingRef.current) return;
  templatesLoadingRef.current = true;
  setTemplatesLoading(true);
  let cancelled = false;
  (async () => {
    try { /* fetch … */  allTemplatesLoadedRef.current = true; }
    finally {
      templatesLoadingRef.current = false;
      if (!cancelled) setTemplatesLoading(false);
    }
  })();
  return () => { cancelled = true; };
}, [showTemplatePicker]);

Walkthrough

PDS verification

The gathering record — including the StrongRef to the facilitator’s curated template — was fetched directly from the user’s PDS before cleanup:

DID=did:plc:cpoagodpqrgs4t7thi5z37uf
curl -s "https://climateai.org/xrpc/com.atproto.repo.listRecords" \
  --data-urlencode "repo=$DID" \
  --data-urlencode "collection=org.simocracy.gathering" -G | jq '.records[0].value'

{
  "$type": "org.simocracy.gathering",
  "name": "Default Constitution Test (post-fix)",
  "status": "application",
  "simSize": "normal",
  "createdAt": "2026-04-20T05:24:24.357Z",
  "gatheringType": "governance",
  "allocationMechanism": "s-process",
  "suggestedInterviewTemplates": [
    {
      "uri": "at://did:plc:awtx57rxuisy4sf4kzzr3uhf/org.simocracy.interviewTemplate/3mjtodp56ps2e",
      "cid": "bafyreihqwpezjm4rck4hhldwp4hltwpvlamkg4ia62pjllb5d26er63cwi"
    }
  ]
}

Findings

Reproducing