simocracy-v2 · gathering-proposal-leaflet-doc-crash

Proposal modal crash from Leaflet-doc descriptions

@daviddao

A user reported that opening a proposal from the GainForest Data Council village threw a runtime error. The crash was caused by a budget parser I’d shipped two commits earlier calling String.prototype.indexOf on a Leaflet document object — the Hyperindexer returns proposal descriptions in that shape, not as plain strings.

Date: 2026-04-25 · Status: fixed · Commit: d1f6737 · URL: /events/did:plc:qc42fmqqlsmdq7jiypiiigww/3miucq2jbzo2s

Headline result

Reproducing the crash

The actual proposal record on this gathering, fetched via Hyperindexer's typed GraphQL endpoint:

$ curl -s -X POST 'https://api.hi.gainforest.app/graphql' -H 'Content-Type: application/json' \
    -d '{"query":"query { orgHypercertsClaimActivity(where: { shortDescription: { contains: \"#gathering-3miucq2jbzo2s\" } }, first: 10) { edges { node { uri title description } } } }"}'

{
  "data": { "orgHypercertsClaimActivity": { "edges": [{
    "node": {
      "uri": "at://did:plc:qc42fmqqlsmdq7jiypiiigww/org.hypercerts.claim.activity/3mkcmuv7x5l23",
      "title": "Pet Dogs",
      "description": {
        "blocks": [
          { "block": {
              "$type": "pub.leaflet.blocks.text",
              "plaintext": "━━━ Budget Request ━━━\n• Dogs — $1,000\n• Cats — $1,964\n━━━ Total: $2,964 ━━━"
          } }
        ]
      }
    }
  }] } }
}

The full payload is committed alongside this report at assets/hyperindexer-payload.json. Feeding the same payload through the OLD vs NEW parser confirms the diagnosis end-to-end:

$ node assets/repro.mjs
typeof description: object
shape: {"blocks":[{"block":{"$type":"pub.leaflet.blocks.text","plaintext":"━━━ Budget Request ━━━\n• …

[OLD parser]
✗ THROWS: text.indexOf is not a function

[NEW parser]
✓ text: "━━━ Budget Request ━━━\n• Dogs — $1,000\n• Cats — $1,964\n━━━ Total: $2,964 ━━━"

Walkthrough

01The gathering page on production after the fix — background loads, three council sims (jigme khesar namgyal wangchuck, ClawBot, Einstein) walk freely. Pre-fix this page mounted but the proposal modal would crash on open; post-fix the modal mounts and the budget block renders as a structured “Requested Budget” section instead of being interpreted as raw markdown.

Findings

export function descriptionToText(input: unknown): string {
  if (input == null) return ""
  if (typeof input === "string") return input
  if (typeof input === "object") {
    const blocks = (input as Record<string, unknown>).blocks
    if (Array.isArray(blocks)) {
      const parts: string[] = []
      for (const entry of blocks) {
        const b = entry && typeof entry === "object"
          ? (entry as Record<string, unknown>).block : null
        if (b && typeof b === "object") {
          const text = (b as Record<string, unknown>).plaintext
          if (typeof text === "string" && text.length > 0) parts.push(text)
        }
      }
      return parts.join("\n\n")
    }
    const text = (input as Record<string, unknown>).text
    if (typeof text === "string") return text
  }
  return ""
}

Reproducing